[webkit-reviews] review granted: [Bug 185611] [GTK][WPE]: Avoid trying to getenv with an unset varname : [Attachment 340429] [GTK][WPE]: Avoid using uninitialized launchOptions in getLaunchOptions

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 185611: [GTK][WPE]: Avoid trying to getenv with an unset varname
https://bugs.webkit.org/show_bug.cgi?id=185611

Attachment 340429: [GTK][WPE]: Avoid using uninitialized launchOptions in
getLaunchOptions

https://bugs.webkit.org/attachment.cgi?id=340429&action=review




--- Comment #13 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 340429
  --> https://bugs.webkit.org/attachment.cgi?id=340429
[GTK][WPE]: Avoid using uninitialized launchOptions in getLaunchOptions

View in context: https://bugs.webkit.org/attachment.cgi?id=340429&action=review

> Source/WebKit/ChangeLog:12
> +	   https://bugs.webkit.org/show_bug.cgi?id=185611

It's redundant as you already have it up above.

> Source/WebKit/UIProcess/ChildProcessProxy.cpp:80
> +	   return;

Always assume the assertion never fails! So remove the return, since it's
supposed to be unreachable. Just let it crash on the next line if the assertion
fails.