[webkit-reviews] review denied: [Bug 185654] Cleanup platform Cookie : [Attachment 340428] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 185654: Cleanup platform Cookie
https://bugs.webkit.org/show_bug.cgi?id=185654

Attachment 340428: Patch

https://bugs.webkit.org/attachment.cgi?id=340428&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 340428
  --> https://bugs.webkit.org/attachment.cgi?id=340428
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340428&action=review

> Source/WebCore/platform/Cookie.h:118
> -    std::optional<String> value;
> -    decoder >> value;
> -    if (!value)
> +    if (!decoder.decode(cookie.value))
>	   return std::nullopt;

This is moving away from the newer way of doing decoding.