[webkit-reviews] review granted: [Bug 185601] [JSC] Check TypeInfo first before calling getCallData when we would like to check whether given object is a function : [Attachment 340393] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 12:32:28 PDT 2018


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185601: [JSC] Check TypeInfo first before calling getCallData when we would
like to check whether given object is a function
https://bugs.webkit.org/show_bug.cgi?id=185601

Attachment 340393: Patch

https://bugs.webkit.org/attachment.cgi?id=340393&action=review




--- Comment #28 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 340393
  --> https://bugs.webkit.org/attachment.cgi?id=340393
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340393&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +	   Rename TypeOfShouldCallGetCallData to OverridesGetCallData. And
check TypeOfShouldCallGetCallData

And check TypeOfShouldCallGetCallData => And check OverridesGetCallData

> Source/JavaScriptCore/runtime/FunctionPrototype.cpp:129
> +	       if (auto* classInfo = object->classInfo(vm)) {

I know this isn't your code, but it's weird that this could be null. I wonder
why this was added.


More information about the webkit-reviews mailing list