[webkit-reviews] review denied: [Bug 185611] [GTK][WPE]: Avoid trying to getenv with an unset varname : [Attachment 340313] [GTK][WPE]: Avoid trying to getenv with an unset varname

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 15 09:23:07 PDT 2018


Michael Catanzaro <mcatanzaro at igalia.com> has denied Thibault Saunier
<tsaunier at gnome.org>'s request for review:
Bug 185611: [GTK][WPE]: Avoid trying to getenv with an unset varname
https://bugs.webkit.org/show_bug.cgi?id=185611

Attachment 340313: [GTK][WPE]: Avoid trying to getenv with an unset varname

https://bugs.webkit.org/attachment.cgi?id=340313&action=review




--- Comment #7 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 340313
  --> https://bugs.webkit.org/attachment.cgi?id=340313
[GTK][WPE]: Avoid trying to getenv with an unset varname

Good catch, Zan. Indeed, something else must be wrong here for
launchOptions.processType to be invalid. The switch would benefit from an
ASSERT_NOT_REACHED() in the default case.


More information about the webkit-reviews mailing list