[webkit-reviews] review requested: [Bug 182622] [CMake] Properly detect compiler flags, needed libs, and fallbacks for usage of 64-bit atomic operations : [Attachment 340404] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 15 04:26:55 PDT 2018
Alberto Garcia <berto at igalia.com> has asked for review:
Bug 182622: [CMake] Properly detect compiler flags, needed libs, and fallbacks
for usage of 64-bit atomic operations
https://bugs.webkit.org/show_bug.cgi?id=182622
Attachment 340404: Patch
https://bugs.webkit.org/attachment.cgi?id=340404&action=review
--- Comment #21 from Alberto Garcia <berto at igalia.com> ---
Created attachment 340404
--> https://bugs.webkit.org/attachment.cgi?id=340404&action=review
Patch
I realized that we already have the test that we need in
Source/WebKit/CMakeLists.txt:
https://github.com/WebKit/webkit/blob/525b5862131cf05ea05bace559173e65da5da827/
Source/WebKit/CMakeLists.txt#L813
(originally from bug 173921)
So we can simply use it in JavaScriptCore. I just tested it in armel
and it seems to work fine. Here's the patch for master.
More information about the webkit-reviews
mailing list