[webkit-reviews] review granted: [Bug 185648] Update animation when presenting QuickLook : [Attachment 340402] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 15 03:29:24 PDT 2018
Antoine Quint <graouts at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 185648: Update animation when presenting QuickLook
https://bugs.webkit.org/show_bug.cgi?id=185648
Attachment 340402: Patch
https://bugs.webkit.org/attachment.cgi?id=340402&action=review
--- Comment #3 from Antoine Quint <graouts at apple.com> ---
Comment on attachment 340402
--> https://bugs.webkit.org/attachment.cgi?id=340402
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=340402&action=review
> Source/WebKit/UIProcess/Cocoa/SystemPreviewControllerCocoa.mm:142
> + frame = CGRectMake(CGRectGetMidX(frame) - 5, CGRectGetMidY(frame) - 5,
10, 10);
You should make 10 a named constant and replace 5 with half that value.
More information about the webkit-reviews
mailing list