[webkit-reviews] review granted: [Bug 185521] AX: Listbox and Combobox roles embedded in labels should participate in name calculation : [Attachment 340368] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Joanmarie Diggs (irc: joanie)
<jdiggs at igalia.com>'s request for review:
Bug 185521: AX: Listbox and Combobox roles embedded in labels should
participate in name calculation
https://bugs.webkit.org/show_bug.cgi?id=185521

Attachment 340368: Patch

https://bugs.webkit.org/attachment.cgi?id=340368&action=review




--- Comment #29 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 340368
  --> https://bugs.webkit.org/attachment.cgi?id=340368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340368&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1419
> +    // find out if this element is inside of a label element.

Find out

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1420
> +    // if so, it may be ignored because it's the label for a checkbox or
radio button

If so