[webkit-reviews] review granted: [Bug 185631] TestWebKitAPI: Fix warnings found by new clang compiler : [Attachment 340365] Patch v1

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 185631: TestWebKitAPI: Fix warnings found by new clang compiler
https://bugs.webkit.org/show_bug.cgi?id=185631

Attachment 340365: Patch v1

https://bugs.webkit.org/attachment.cgi?id=340365&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 340365
  --> https://bugs.webkit.org/attachment.cgi?id=340365
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=340365&action=review

> Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:178
> +#pragma clang diagnostic ignored "-Wunknown-pragmas"
> +#pragma clang diagnostic ignored "-Wself-assign-overloaded"

I think it would be good form to use two pops now to return the diagnostic
stack to its original state, not that it matters.

> Tools/TestWebKitAPI/Tests/WebKit/FindMatches.mm:88
> +	       unusedRect = WKRectGetValue(reinterpret_cast<WKRectRef>(items));

Can you not just drop the return value? Or cast the result to void?