[webkit-reviews] review granted: [Bug 185575] Overly aggressive timer throttling in service workers : [Attachment 340355] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 185575: Overly aggressive timer throttling in service workers
https://bugs.webkit.org/show_bug.cgi?id=185575

Attachment 340355: Patch

https://bugs.webkit.org/attachment.cgi?id=340355&action=review




--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 340355
  --> https://bugs.webkit.org/attachment.cgi?id=340355
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340355&action=review

> Source/WebKit/UIProcess/ServiceWorkerProcessProxy.cpp:113
> +    // Prevent App Nap for Service Worker processes.
> +    setProcessSuppressionEnabled(false);

I think we want a FIXME with a link to a bugzilla bug that says Service Workers
should nap if all their clients are napping. It's not a high priority bug, but
it's good to clarify that's the design that we think would be best.