[webkit-reviews] review granted: [Bug 182950] Web Inspector: Canvas tab: don't automatically select a recording when viewing a canvas : [Attachment 334215] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 14 13:30:26 PDT 2018


Matt Baker <mattbaker at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 182950: Web Inspector: Canvas tab: don't automatically select a recording
when viewing a canvas
https://bugs.webkit.org/show_bug.cgi?id=182950

Attachment 334215: Patch

https://bugs.webkit.org/attachment.cgi?id=334215&action=review




--- Comment #5 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 334215
  --> https://bugs.webkit.org/attachment.cgi?id=334215
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334215&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js:42
> +	   this._canvasTreeOutline.allowsRepeatSelection = true;

I think this change deserves an explanation in the change log.


More information about the webkit-reviews mailing list