[webkit-reviews] review denied: [Bug 185601] [JSC] Check TypeOfShouldCallGetCallData before calling getCallData when we would like to check whether a given object is callable : [Attachment 340295] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has denied Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185601: [JSC] Check TypeOfShouldCallGetCallData before calling getCallData
when we would like to check whether a given object is callable
https://bugs.webkit.org/show_bug.cgi?id=185601

Attachment 340295: Patch

https://bugs.webkit.org/attachment.cgi?id=340295&action=review




--- Comment #11 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 340295
  --> https://bugs.webkit.org/attachment.cgi?id=340295
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340295&action=review

> Source/JavaScriptCore/runtime/JSONObject.cpp:385
> +    if (object->inherits<JSFunction>(vm)

Just doing this optimization for JSFunction inside of JSON code feels like the
wrong level of abstraction. I’d advocate for writing a new helper for
getCallSata and you can put optimization’s in that, and switch to using that
helper here (and maybe elsewhere)