[webkit-reviews] review granted: [Bug 185585] [LFC] Implement height computation for non-replaced out of flow elements. : [Attachment 340282] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 185585: [LFC] Implement height computation for non-replaced out of flow
elements.
https://bugs.webkit.org/show_bug.cgi?id=185585

Attachment 340282: Patch

https://bugs.webkit.org/attachment.cgi?id=340282&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 340282
  --> https://bugs.webkit.org/attachment.cgi?id=340282
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340282&action=review

> Source/WebCore/layout/FormattingContext.cpp:180
> +	   computedHeightValue=
contentHeightForFormattingContextRoot(layoutContext, layoutBox);

Missing space before =

> Source/WebCore/layout/FormattingContext.cpp:207
> +    if (!is<Container>(layoutBox) ||
!downcast<Container>(layoutBox).hasInFlowOrFloatingChild()) {
> +	   return 0;
>      }

Unneeded { }