[webkit-reviews] review granted: [Bug 185578] [INTL] Improve spec & test262 compliance for Intl APIs : [Attachment 340250] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Andy VanWagoner
<andy at vanwagoner.family>'s request for review:
Bug 185578: [INTL] Improve spec & test262 compliance for Intl APIs
https://bugs.webkit.org/show_bug.cgi?id=185578

Attachment 340250: Patch

https://bugs.webkit.org/attachment.cgi?id=340250&action=review




--- Comment #3 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 340250
  --> https://bugs.webkit.org/attachment.cgi?id=340250
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340250&action=review

r=me

> Source/JavaScriptCore/runtime/IntlDateTimeFormatPrototype.cpp:92
> +    putDirectWithoutTransition(vm, vm.propertyNames->toStringTagSymbol,
jsString(&vm, "Object"), PropertyAttribute::DontEnum |
PropertyAttribute::ReadOnly);

Use vm.propertyNames->Object

> Source/JavaScriptCore/runtime/IntlPluralRules.cpp:229
>      // Category names are always ASCII, so use char[].

Put `index` here.