[webkit-reviews] review granted: [Bug 185580] Implement SVGGeometryElement's isPointInFill and isPointInStroke : [Attachment 340249] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 185580: Implement SVGGeometryElement's isPointInFill and isPointInStroke
https://bugs.webkit.org/show_bug.cgi?id=185580

Attachment 340249: Patch

https://bugs.webkit.org/attachment.cgi?id=340249&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 340249
  --> https://bugs.webkit.org/attachment.cgi?id=340249
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340249&action=review

> Source/WebCore/rendering/svg/RenderSVGRect.h:53
> +    bool shapeDependentStrokeContains(const FloatPoint&, bool
isInLocalCoordinateSystem = false) override;

How about

enum class CoordinateSystem { Global, Local } 

or similar? Booleans can be confusing in call sites.