[webkit-reviews] review granted: [Bug 185427] Add test to verify behavior of -webkit-text-fill-color when inherited : [Attachment 340223] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 185427: Add test to verify behavior of -webkit-text-fill-color when
inherited
https://bugs.webkit.org/show_bug.cgi?id=185427

Attachment 340223: Patch

https://bugs.webkit.org/attachment.cgi?id=340223&action=review




--- Comment #7 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 340223
  --> https://bugs.webkit.org/attachment.cgi?id=340223
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340223&action=review

Thank you for iterating on this patch, Aditya.
r=me

> LayoutTests/fast/css/webkit-text-fill-color-inherit.html:5
> +	   <div id="undefined-parent" style="color: red;
-webkit-text-fill-color: inherit">Green</div>

This is OK as-is. We are not using this id.

> LayoutTests/fast/css/webkit-text-fill-color-inherit.html:8
> +	   <div id="defined-parent" style="color: red; -webkit-text-fill-color:
inherit">Green</div>

Ditto.