[webkit-reviews] review granted: [Bug 185535] [EME][GStreamer] Handle the protection event in MediaPlayerPrivate : [Attachment 340149] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 185535: [EME][GStreamer] Handle the protection event in MediaPlayerPrivate
https://bugs.webkit.org/show_bug.cgi?id=185535

Attachment 340149: Patch

https://bugs.webkit.org/attachment.cgi?id=340149&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 340149
  --> https://bugs.webkit.org/attachment.cgi?id=340149
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340149&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
1217
> +    if (m_cdmInstance &&
strcmp(GStreamerEMEUtilities::keySystemToUuid(m_cdmInstance->keySystem()),
eventKeySystemUUID))

Better to use g_strcmp0.
It would be interesting to add a GST_TRACE or DEBUG comment for the bail out
here.