[webkit-reviews] review granted: [Bug 185539] Don't use inferred types when the JIT is disabled : [Attachment 340169] patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 185539: Don't use inferred types when the JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=185539

Attachment 340169: patch

https://bugs.webkit.org/attachment.cgi?id=340169&action=review




--- Comment #4 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 340169
  --> https://bugs.webkit.org/attachment.cgi?id=340169
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340169&action=review

>>> Source/JavaScriptCore/runtime/VM.h:558
>>> +	 ALWAYS_INLINE bool canUseJIT() const { return m_canUseJIT; }
>> 
>> Why do we change this to VM's member function? IIRC, our CSSJIT selector
compiler uses VM::canUseJIT(). And since it is a static function, we can remove
VM& reference from CSS JIT compiler.
> 
> I just wanted it to be a single load instead of an out of line function call.
I didn't realize the CSSJIT uses this. I'll fix that.

OK, it is performance reason. If it is critical, I'm OK to have m_canUseJIT in
VM side :)