[webkit-reviews] review granted: [Bug 182589] REGRESSION(r227983): fast/dom/adopt-node-crash-2.html is flaky : [Attachment 340165] Speculative fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 10 21:26:55 PDT 2018


Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 182589: REGRESSION(r227983): fast/dom/adopt-node-crash-2.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=182589

Attachment 340165: Speculative fix

https://bugs.webkit.org/attachment.cgi?id=340165&action=review




--- Comment #9 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 340165
  --> https://bugs.webkit.org/attachment.cgi?id=340165
Speculative fix

View in context: https://bugs.webkit.org/attachment.cgi?id=340165&action=review

> LayoutTests/fast/dom/adopt-node-crash-2.html:39
>      setTimeout("doit()", 1);

The `1` is an interesting choice here. Does it not work if we schedule this on
a 0-delay timer?


More information about the webkit-reviews mailing list