[webkit-reviews] review denied: [Bug 185381] Remove Document#selectedStylesheetSet/preferredStylesheetSet : [Attachment 340137] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 10 19:50:06 PDT 2018


Daniel Bates <dbates at webkit.org> has denied Chris Nardi <cnardi at chromium.org>'s
request for review:
Bug 185381: Remove Document#selectedStylesheetSet/preferredStylesheetSet
https://bugs.webkit.org/show_bug.cgi?id=185381

Attachment 340137: Patch

https://bugs.webkit.org/attachment.cgi?id=340137&action=review




--- Comment #6 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 340137
  --> https://bugs.webkit.org/attachment.cgi?id=340137
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340137&action=review

> Source/WebKitLegacy/mac/DOM/DOMDocument.h:84
> - at property (readonly, copy) NSString *preferredStylesheetSet
WEBKIT_AVAILABLE_MAC(10_5);
> - at property (copy) NSString *selectedStylesheetSet WEBKIT_AVAILABLE_MAC(10_5);
>  @property (readonly, strong) DOMElement *activeElement
WEBKIT_AVAILABLE_MAC(10_6);

This is public Mac API. We cannot remove these without deprecated them first.

<https://developer.apple.com/documentation/webkit/domdocument/1494907-selecteds
tylesheetset?language=objc>
<https://developer.apple.com/documentation/webkit/domdocument/1494857-preferred
stylesheetset?language=objc>


More information about the webkit-reviews mailing list