[webkit-reviews] review granted: [Bug 185090] REGRESSION (r230998): Cannot stream API test output : [Attachment 339123] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 185090: REGRESSION (r230998): Cannot stream API test output
https://bugs.webkit.org/show_bug.cgi?id=185090

Attachment 339123: Patch

https://bugs.webkit.org/attachment.cgi?id=339123&action=review




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 339123
  --> https://bugs.webkit.org/attachment.cgi?id=339123
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339123&action=review

> Tools/Scripts/webkitpy/api_tests/runner.py:53
> +	   self._has_logged_for_test = True

We should add a comment here saying this would suppress an empty line between
"Running tests" and the first test's output.

> Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py:57
> +	   self._print_timestamps = verbose if print_timestamps is None else
print_timestamps

It's a bit odd that this falls back to verbose but I guess changing it
everywhere would be a lot of code changes.