[webkit-reviews] review denied: [Bug 185482] Update Test262 tests through the new import script - 20180509 : [Attachment 340117] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 10 13:00:09 PDT 2018


Michael Saboff <msaboff at apple.com> has denied Leo Balter
<leonardo.balter at gmail.com>'s request for review:
Bug 185482: Update Test262 tests through the new import script - 20180509
https://bugs.webkit.org/show_bug.cgi?id=185482

Attachment 340117: Patch

https://bugs.webkit.org/attachment.cgi?id=340117&action=review




--- Comment #15 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 340117
  --> https://bugs.webkit.org/attachment.cgi?id=340117
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340117&action=review

r-

> JSTests/ChangeLog:7
> +	   Update Test262 tests through the new import script - 20180509
> +
> +	   Also update the test262/expecatations.yaml with the recent
> +	   imported files.
> +	   https://bugs.webkit.org/show_bug.cgi?id=185482

The format of a ChangeLog should be:
    Title
    Bug URL

    Reviewed by ...

    Description

Please move the "Also update..." to after Reviewed By ...


More information about the webkit-reviews mailing list