[webkit-reviews] review denied: [Bug 184996] Add initial support for 'Cross-Origin-Options' HTTP response header : [Attachment 340042] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied	review:
Bug 184996: Add initial support for 'Cross-Origin-Options' HTTP response header
https://bugs.webkit.org/show_bug.cgi?id=184996

Attachment 340042: Patch

https://bugs.webkit.org/attachment.cgi?id=340042&action=review




--- Comment #51 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 340042
  --> https://bugs.webkit.org/attachment.cgi?id=340042
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340042&action=review

> Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl:229
>      HRESULT setMenuItemElementEnabled([in] BOOL enabled);

}

[uuid(<<Generate and fill in some kind of UUID here>>)]
interface IWebPreferencesPrivate7 : IWebPreferencesPrivate6
{

> Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl:231
> +    HRESULT setCrossOriginOptionsSupportEnabled([in] BOOL enabled);

You can't add these here without breaking existing WebKit clients on Windows
(e.g., iTunes).

Instead, we have to create a new IWebPreferencesPrivate7 with these two new
values.

> Source/WebKitLegacy/win/WebView.cpp:5152
>  

COMPtr<IWebPreferencesPrivate7> prefsPrivate { Query, preferences };

> Source/WebKitLegacy/win/WebView.cpp:5158
>      COMPtr<IWebPreferencesPrivate6> prefsPrivate { Query, preferences };

Then delete this one line ^^^