[webkit-reviews] review granted: [Bug 184996] Add initial support for 'Cross-Origin-Options' HTTP response header : [Attachment 340042] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted  review:
Bug 184996: Add initial support for 'Cross-Origin-Options' HTTP response header
https://bugs.webkit.org/show_bug.cgi?id=184996

Attachment 340042: Patch

https://bugs.webkit.org/attachment.cgi?id=340042&action=review




--- Comment #49 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 340042
  --> https://bugs.webkit.org/attachment.cgi?id=340042
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340042&action=review

r=me if EWS is happy

> Source/WebCore/dom/Document.cpp:7815
> +void Document::setCrossOriginOptions(CrossOriginOptions value)
> +{
> +    m_crossOriginOptions = value;
> +    if (auto* window = domWindow())
> +	   window->setCrossOriginOptions(value);
> +}

Do we need to propagate m_crossOriginOptions inside Document::createDOMWindow()
(covering the case where domWindow() is null at this point)?