[webkit-reviews] review granted: [Bug 185457] Speed up AbstractInterpreter::executeEdges : [Attachment 340001] the patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 185457: Speed up AbstractInterpreter::executeEdges
https://bugs.webkit.org/show_bug.cgi?id=185457

Attachment 340001: the patch

https://bugs.webkit.org/attachment.cgi?id=340001&action=review




--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 340001
  --> https://bugs.webkit.org/attachment.cgi?id=340001
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=340001&action=review

r=me
but I think you have a function you forgot to call for the fast path

> Source/JavaScriptCore/ChangeLog:31
> +	   But that fix revealed an amazing timeout in

what an adventure

> Source/JavaScriptCore/dfg/DFGAbstractValue.h:343
> +    ALWAYS_INLINE FiltrationResult
fastForwardToAndFilter(AbstractValueClobberEpoch newEpoch, SpeculatedType type)

This doesn't seem to be called from anywhere. Maybe InPlaceAbstractState was
supposed to call this instead of the below function?