[webkit-reviews] review granted: [Bug 185472] [iOS] Consider the annotation bounds when positioning action sheets near long-pressed PDF links : [Attachment 339964] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 9 11:40:03 PDT 2018


Daniel Bates <dbates at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 185472: [iOS] Consider the annotation bounds when positioning action sheets
near long-pressed PDF links
https://bugs.webkit.org/show_bug.cgi?id=185472

Attachment 339964: Patch

https://bugs.webkit.org/attachment.cgi?id=339964&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 339964
  --> https://bugs.webkit.org/attachment.cgi?id=339964
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339964&action=review

r=me

> Source/WebKit/ChangeLog:14
> +	   We also no longer need to convert the press location into host view
coordinate
> +	   space, as PDFKit now does that for us.

Cool.


More information about the webkit-reviews mailing list