[webkit-reviews] review granted: [Bug 185383] NSEvent event trackers don't work from WebKitTestRunner for simulated wheel events. : [Attachment 339987] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 9 11:29:44 PDT 2018
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jeremy Jones
<jeremyj-wk at apple.com>'s request for review:
Bug 185383: NSEvent event trackers don't work from WebKitTestRunner for
simulated wheel events.
https://bugs.webkit.org/show_bug.cgi?id=185383
Attachment 339987: Patch
https://bugs.webkit.org/attachment.cgi?id=339987&action=review
--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 339987
--> https://bugs.webkit.org/attachment.cgi?id=339987
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=339987&action=review
> LayoutTests/swipe/wheel-event-initiated-back-navigation.html:25
> + logResult('This test must be run in
DumpRenderTree/WebKitTestRunner (no eventSender)');
> + return;
Weird indentation. Tabs?
> LayoutTests/swipe/wheel-event-initiated-back-navigation.html:30
> + logResult('This test must be run in
DumpRenderTree/WebKitTestRunner (no testRunner)');
> + return;
Weird indentation. Tabs?
> LayoutTests/swipe/wheel-event-initiated-back-navigation.html:63
> +<h1>This is a swipe navigation test.</h1>
Is it?
More information about the webkit-reviews
mailing list