[webkit-reviews] review requested: [Bug 184588] [GStreamer] Fix the way GstStreamCollection is handled : [Attachment 339991] [GStreamer] Fix the way GstStreamCollection is handled
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 9 11:21:04 PDT 2018
Thibault Saunier <tsaunier at gnome.org> has asked for review:
Bug 184588: [GStreamer] Fix the way GstStreamCollection is handled
https://bugs.webkit.org/show_bug.cgi?id=184588
Attachment 339991: [GStreamer] Fix the way GstStreamCollection is handled
https://bugs.webkit.org/attachment.cgi?id=339991&action=review
--- Comment #9 from Thibault Saunier <tsaunier at gnome.org> ---
Created attachment 339991
--> https://bugs.webkit.org/attachment.cgi?id=339991&action=review
[GStreamer] Fix the way GstStreamCollection is handled
The stream collection message replaces the collection of stream previously
advertised, this means that we should rebuild our set of Track from scratch
and not update previously exposed tracks.
In the end, this simplifies the code as we do not care about what
tracks existed previously, we just need to expose what GStreamer tells
us, deleting any previous state.
Handle the STREAM_COLLECTION message from the sync handler so that tracks
are updated before we mark the pipeline as READY for the live case (everything
happen synchronously with the call to the `load()` method in that case),
still the update happens on the main thread.
More information about the webkit-reviews
mailing list