[webkit-reviews] review canceled: [Bug 185421] [Win] Enable poisoning in 64bit Windows : [Attachment 339959] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 9 10:36:02 PDT 2018


Yusuke Suzuki <utatane.tea at gmail.com> has canceled Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185421: [Win] Enable poisoning in 64bit Windows
https://bugs.webkit.org/show_bug.cgi?id=185421

Attachment 339959: Patch

https://bugs.webkit.org/attachment.cgi?id=339959&action=review




--- Comment #3 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 339959
  --> https://bugs.webkit.org/attachment.cgi?id=339959
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339959&action=review

> Source/JavaScriptCore/offlineasm/x86.rb:67
> +# rcx => t5, a0

This is not correct. While t5 is actually rcx in baseline JIT side, this does
not meet the requirement in LLInt.


More information about the webkit-reviews mailing list