[webkit-reviews] review granted: [Bug 185462] [WPE] Build cleanly with GCC 8 and ICU 60 : [Attachment 339928] Patch

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 185462: [WPE] Build cleanly with GCC 8 and ICU 60
https://bugs.webkit.org/show_bug.cgi?id=185462

Attachment 339928: Patch

https://bugs.webkit.org/attachment.cgi?id=339928&action=review




--- Comment #4 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 339928
  --> https://bugs.webkit.org/attachment.cgi?id=339928
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339928&action=review

it looks ok, but i think those extra breaks added to make gcc8 happy should be
changed by ASSERT_NOT_REACHED() instead.

> Source/JavaScriptCore/b3/air/AirArg.h:892
> +	       break;

I think this one should be ASSERT_NOT_REACHED(); instead of break
Also.. why this change is not needed also in castToType() 20 lines below?

> Source/JavaScriptCore/dfg/DFGDoubleFormatState.h:51
> +	   break;

ASSERT_NOT_REACHED();

> Source/JavaScriptCore/dfg/DFGDoubleFormatState.h:61
> +	   break;

ASSERT_NOT_REACHED();

> Source/JavaScriptCore/heap/MarkedBlockInlines.h:391
> +		   break;

ASSERT_NOT_REACHED();

> Source/JavaScriptCore/heap/MarkedBlockInlines.h:402
> +	       break;

ASSERT_NOT_REACHED();

> Source/JavaScriptCore/heap/MarkedBlockInlines.h:414
> +		   break;

ASSERT_NOT_REACHED();

> Source/WebCore/css/CSSFontFace.cpp:608
> +	   break;

ASSERT_NOT_REACHED();