[webkit-reviews] review granted: [Bug 185198] [GTK] REGRESSION(r231170) Build broken with Clang 5.0 : [Attachment 339946] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 185198: [GTK] REGRESSION(r231170) Build broken with Clang 5.0
https://bugs.webkit.org/show_bug.cgi?id=185198

Attachment 339946: Patch

https://bugs.webkit.org/attachment.cgi?id=339946&action=review




--- Comment #20 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 339946
  --> https://bugs.webkit.org/attachment.cgi?id=339946
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339946&action=review

> Source/WTF/wtf/StdLibExtras.h:548
> +// Provide in_place_t when not building with -std=c++17, or when building
with libstdc++ 6
> +// (which doesn't define the _GLIBCXX_RELEASE macro that's been introduced
in libstdc++ 7).
> +#if __cplusplus < 201703L || (defined(__GLIBCXX__) &&
!defined(_GLIBCXX_RELEASE))

Wow, it looks like there's really no better way to do this. Yuck.

https://stackoverflow.com/questions/31506594/how-do-i-test-the-version-of-libst
dc-not-gcc-at-compile-time has no good solutions.