[webkit-reviews] review granted: [Bug 185269] Range bisector should check the commits for repositories without change in specified range. : [Attachment 339488] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 185269: Range bisector should check the commits for repositories without
change in specified range.
https://bugs.webkit.org/show_bug.cgi?id=185269

Attachment 339488: Patch

https://bugs.webkit.org/attachment.cgi?id=339488&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 339488
  --> https://bugs.webkit.org/attachment.cgi?id=339488
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339488&action=review

> Websites/perf.webkit.org/ChangeLog:16
> +	   (async):

Remove this?

> Websites/perf.webkit.org/public/v3/commit-set-range-bisector.js:35
> +	       let commits = null;
> +	       if (startCommit !== endCommit)
> +		   commits = await CommitLog.fetchBetweenRevisions(repository,
startCommit.revision(), endCommit.revision());
> +	       else
> +		   commits = [startCommit];

How about just this?
cont commits = startCommit == endCommit ? [startCommit] : await
CommitLog.fetchBetweenRevisions(repository, startCommit.revision(),
endCommit.revision());