[webkit-reviews] review granted: [Bug 185272] [WebGL] WEBGL_compressed_texture_astc support : [Attachment 339777] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted  review:
Bug 185272: [WebGL] WEBGL_compressed_texture_astc support
https://bugs.webkit.org/show_bug.cgi?id=185272

Attachment 339777: Patch

https://bugs.webkit.org/attachment.cgi?id=339777&action=review




--- Comment #15 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 339777
  --> https://bugs.webkit.org/attachment.cgi?id=339777
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339777&action=review

> Source/WebCore/html/canvas/WebGLCompressedTextureASTC.h:43
> +    bool m_isHDRSupported : 1;

I thought the style checker required that these be unsigned ints

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5398
> +	   BlockParameters(4, 4, kASTCBlockSize),

You should use { } notation to construct the structs instead of constructors