[webkit-reviews] review granted: [Bug 185440] Add tests to ensure that the Strong Password appearance is removed on form reset : [Attachment 339854] Tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 8 14:39:58 PDT 2018
Ryosuke Niwa <rniwa at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 185440: Add tests to ensure that the Strong Password appearance is removed
on form reset
https://bugs.webkit.org/show_bug.cgi?id=185440
Attachment 339854: Tests
https://bugs.webkit.org/attachment.cgi?id=339854&action=review
--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 339854
--> https://bugs.webkit.org/attachment.cgi?id=339854
Tests
View in context: https://bugs.webkit.org/attachment.cgi?id=339854&action=review
>
LayoutTests/fast/forms/auto-fill-button/hide-auto-fill-strong-password-button-w
hen-form-is-reset.html:14
> + let form = document.querySelector("form");
> + form.reset();
It seems like we don't need this local variable.
Just do: document.querySelector("form").reset(). Or simply
document.forms[0].reset()?
More information about the webkit-reviews
mailing list