[webkit-reviews] review granted: [Bug 185432] Consecutive messages logged as JSON are coalesced : [Attachment 339847] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 185432: Consecutive messages logged as JSON are coalesced
https://bugs.webkit.org/show_bug.cgi?id=185432

Attachment 339847: Patch

https://bugs.webkit.org/attachment.cgi?id=339847&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 339847
  --> https://bugs.webkit.org/attachment.cgi?id=339847
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339847&action=review

r=me

> LayoutTests/inspector/console/webcore-logging.html:165
> +	   name: "Console.Logging.LogAsJSON",

Maybe this should mention not repeating?
Console.Logging.LogAsJSONWithoutRepeat"

> LayoutTests/inspector/console/webcore-logging.html:192
> +			   if (++messageCount == 3) {

Style: We prefer `===` where possible, but tests we can be lenient on style.
Feel free to cq as is.