[webkit-reviews] review granted: [Bug 185437] Log rtcstats as JSON : [Attachment 339849] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 8 11:49:08 PDT 2018


youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 185437: Log rtcstats as JSON
https://bugs.webkit.org/show_bug.cgi?id=185437

Attachment 339849: Patch

https://bugs.webkit.org/attachment.cgi?id=339849&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 339849
  --> https://bugs.webkit.org/attachment.cgi?id=339849
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339849&action=review

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:1048
> +    RTCStatsLogger(const webrtc::RTCStats& stats)

explicit probably.

> Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:1127
> +	   return WTF::String(logger.toJSONString());

Do we need WTF::?


More information about the webkit-reviews mailing list