[webkit-reviews] review granted: [Bug 185374] [BigInt] Simplifying JSBigInt by using bool addition : [Attachment 339711] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 185374: [BigInt] Simplifying JSBigInt by using bool addition
https://bugs.webkit.org/show_bug.cgi?id=185374

Attachment 339711: Patch

https://bugs.webkit.org/attachment.cgi?id=339711&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 339711
  --> https://bugs.webkit.org/attachment.cgi?id=339711
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339711&action=review

> Source/JavaScriptCore/runtime/JSBigInt.cpp:263
> +    carry += static_cast<bool>(result < a);

I'm not sure if the static_cast<bool>s are necessary