[webkit-reviews] review granted: [Bug 185261] Adopt new async _savecookies SPI for keeping networking process active during flushing cookies : [Attachment 339825] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 185261: Adopt new async _savecookies SPI for keeping networking process
active during flushing cookies
https://bugs.webkit.org/show_bug.cgi?id=185261

Attachment 339825: Patch

https://bugs.webkit.org/attachment.cgi?id=339825&action=review




--- Comment #17 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 339825
  --> https://bugs.webkit.org/attachment.cgi?id=339825
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339825&action=review

r=me

> Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:238
> +    WebCore::NetworkStorageSession::forEach([&] (const auto&
networkStorageSession) {

out of curiosity, was the const really needed? We tend to omit it and let the
auto take care of it.