[webkit-reviews] review granted: [Bug 185261] Adopt new async _savecookies SPI for keeping networking process active during flushing cookies : [Attachment 339801] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 185261: Adopt new async _savecookies SPI for keeping networking process
active during flushing cookies
https://bugs.webkit.org/show_bug.cgi?id=185261

Attachment 339801: Patch

https://bugs.webkit.org/attachment.cgi?id=339801&action=review




--- Comment #15 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 339801
  --> https://bugs.webkit.org/attachment.cgi?id=339801
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339801&action=review

r=me with nits.

> Source/WebKit/ChangeLog:10
> +	   before cookies are fully synced to disk with process assertion.

s/before/until

> Source/WebKit/NetworkProcess/NetworkProcess.h:33
> +#include "NetworkProcessMessages.h"

This include should not be needed.

> Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm:238
> +    WebCore::NetworkStorageSession::forEach([&] (const
WebCore::NetworkStorageSession& networkStorageSession) {

I think we can use "auto& networkStorageSession" here since C++14.