[webkit-reviews] review granted: [Bug 185245] [EME][GStreamer] Add a handler for GStreamer protection event : [Attachment 339713] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 185245: [EME][GStreamer] Add a handler for GStreamer protection event
https://bugs.webkit.org/show_bug.cgi?id=185245

Attachment 339713: Patch

https://bugs.webkit.org/attachment.cgi?id=339713&action=review




--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 339713
  --> https://bugs.webkit.org/attachment.cgi?id=339713
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339713&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
-1270
> -    ASSERT_NOT_REACHED();

Please, leave this outside the patch. If you need this out of here, create a
new bug and set a dependency to this one.

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:1093
> +    GST_DEBUG("Handling event %s on appendPipeline appsinkPad",
GST_EVENT_TYPE_NAME(event));

appendPipeline -> append pipeline