[webkit-reviews] review granted: [Bug 185394] Avoid traversing the FrameTree up in FrameTree::top() : [Attachment 339754] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 7 18:58:52 PDT 2018


Sam Weinig <sam at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 185394: Avoid traversing the FrameTree up in FrameTree::top()
https://bugs.webkit.org/show_bug.cgi?id=185394

Attachment 339754: Patch

https://bugs.webkit.org/attachment.cgi?id=339754&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 339754
  --> https://bugs.webkit.org/attachment.cgi?id=339754
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339754&action=review

> Source/WebCore/ChangeLog:12
> +	   of returning the frame itself). However, it should not matter in
practice as we should
> +	   not be dealing with the FrameTree of a detached frame.

Do we want to / can we assert this?


More information about the webkit-reviews mailing list