[webkit-reviews] review granted: [Bug 184584] [MIPS] Optimize generated JIT code using mips32r2 instructions : [Attachment 339717] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <utatane.tea at gmail.com> has granted Srdjan Lazarevic
<srdjan.lazarevic at rt-rk.com>'s request for review:
Bug 184584: [MIPS] Optimize generated JIT code using mips32r2 instructions
https://bugs.webkit.org/show_bug.cgi?id=184584

Attachment 339717: Patch

https://bugs.webkit.org/attachment.cgi?id=339717&action=review




--- Comment #10 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 339717
  --> https://bugs.webkit.org/attachment.cgi?id=339717
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339717&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerMIPS.h:323
> +    void loadAddress(BaseIndex address, bool loadTrail = true)

Use `enum class` instead of `bool`. In this case, not using default parameter
is better.
And `loadTrail` is a bit confusing. Maybe, `enum class LoadAddressMode {
DontAddOffset, AddOffset };` would be more descriptive.