[webkit-reviews] review granted: [Bug 185329] Make a compact version of VariableEnvironment that UnlinkedFunctionExecutable stores and hash-cons these compact environments as we make them : [Attachment 339765] patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 185329: Make a compact version of VariableEnvironment that
UnlinkedFunctionExecutable stores and hash-cons these compact environments as
we make them
https://bugs.webkit.org/show_bug.cgi?id=185329

Attachment 339765: patch

https://bugs.webkit.org/attachment.cgi?id=339765&action=review




--- Comment #7 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 339765
  --> https://bugs.webkit.org/attachment.cgi?id=339765
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339765&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +	   use space to represent and UnlinkedFunctionExecutable's parent TDZ
variables.

*an*

> Source/JavaScriptCore/parser/VariableEnvironment.cpp:101
> +    m_isEverythingCaptured = env.isEverythingCaptured();

Change this to a member initializer list.