[webkit-reviews] review denied: [Bug 185335] Add experimental feature to prompt for Storage Access API use : [Attachment 339766] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 7 16:39:12 PDT 2018


Alex Christensen <achristensen at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 185335: Add experimental feature to prompt for Storage Access API use
https://bugs.webkit.org/show_bug.cgi?id=185335

Attachment 339766: Patch

https://bugs.webkit.org/attachment.cgi?id=339766&action=review




--- Comment #44 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 339766
  --> https://bugs.webkit.org/attachment.cgi?id=339766
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339766&action=review

> Source/WebKit/UIProcess/WebPageProxy.cpp:7490
> +	   RunLoop::main().dispatch([this, protectedThis = makeRef(*this),
requestingDomain = WTFMove(requestingDomain), currentDomain =
WTFMove(currentDomain), promptEnabled, wasGranted, frameID, completionHandler =
WTFMove(completionHandler)] () mutable {

This should be in WebResourceLoadStatisticsStore::requestStorageAccess


More information about the webkit-reviews mailing list