[webkit-reviews] review granted: [Bug 185287] DFG AI should have O(1) clobbering : [Attachment 339687] the patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 185287: DFG AI should have O(1) clobbering
https://bugs.webkit.org/show_bug.cgi?id=185287

Attachment 339687: the patch

https://bugs.webkit.org/attachment.cgi?id=339687&action=review




--- Comment #15 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 339687
  --> https://bugs.webkit.org/attachment.cgi?id=339687
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339687&action=review

r=me

> Source/JavaScriptCore/dfg/DFGAbstractValue.h:409
> +    // FIXME: Explain this. (OOPS!!)

oops

> Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h:55
> +    ALWAYS_INLINE AbstractValue& forNode(Edge edge)

Why doesn't this need to fastForward as well?