[webkit-reviews] review granted: [Bug 185365] InPlaceAbstractState::beginBasicBlock shouldn't have to clear any abstract values : [Attachment 339690] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 7 15:31:32 PDT 2018


Saam Barati <sbarati at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 185365: InPlaceAbstractState::beginBasicBlock shouldn't have to clear any
abstract values
https://bugs.webkit.org/show_bug.cgi?id=185365

Attachment 339690: the patch

https://bugs.webkit.org/attachment.cgi?id=339690&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 339690
  --> https://bugs.webkit.org/attachment.cgi?id=339690
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339690&action=review

r=me

> Source/WTF/wtf/TinyPtrSet.h:30
> +#include <wtf/DataLog.h>

no need for this.

> Tools/ChangeLog:8
> +	   Make it possible to measure compile times.

nice!


More information about the webkit-reviews mailing list