[webkit-reviews] review granted: [Bug 185333] [iOS] Release page load process assertion if the screen is locked : [Attachment 339611] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 185333: [iOS] Release page load process assertion if the screen is locked
https://bugs.webkit.org/show_bug.cgi?id=185333

Attachment 339611: Patch

https://bugs.webkit.org/attachment.cgi?id=339611&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 339611
  --> https://bugs.webkit.org/attachment.cgi?id=339611
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339611&action=review

r=me

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:683
> +    // We normally delay process suspension when the app is backgrounded
until the current page load completes. However,
> +    // we do not want to do so when the screen is locked for power reasons.

FWIW, I think we also consider screen lock to be a strong signal that the user
isn't interested in that loaded webpage anymore.

Simple backgrounding can happen just by switching between apps, even in a
workflow where you mean to use both apps. So, in that case, we want to avoid
failing the load. But screen lock is not a part of any meaningful intentional
workflow. It's what you do before you put the device away.