[webkit-reviews] review granted: [Bug 185377] [LFC] Add FormattingContext::layoutOutOfFlowDescendants implementation : [Attachment 339718] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 185377: [LFC] Add FormattingContext::layoutOutOfFlowDescendants
implementation
https://bugs.webkit.org/show_bug.cgi?id=185377

Attachment 339718: Patch

https://bugs.webkit.org/attachment.cgi?id=339718&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 339718
  --> https://bugs.webkit.org/attachment.cgi?id=339718
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339718&action=review

> Source/WebCore/layout/FormattingContext.h:66
> -    const LayoutContext& layoutContext() const { return m_layoutContext; }
> +    LayoutContext& layoutContext() const { return m_layoutContext; }

I'm not sure I understand what the intention with constness here is. If
LayoutContext is part of the FormattingContext and it is mutated during layout
then functions like FormattingContext::layoutOutOfFlowDescendants() probably
shouldn't be const in the first place.