[webkit-reviews] review granted: [Bug 185388] REGRESSION(r211075): Web Inspector throws an exception when inspecting WebViews on iOS 8.4 simulator : [Attachment 339737] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 185388: REGRESSION(r211075): Web Inspector throws an exception when
inspecting WebViews on iOS 8.4 simulator
https://bugs.webkit.org/show_bug.cgi?id=185388

Attachment 339737: Patch

https://bugs.webkit.org/attachment.cgi?id=339737&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 339737
  --> https://bugs.webkit.org/attachment.cgi?id=339737
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339737&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:132
> -	   if (HeapAgent.gc)
> +	   // COMPATIBILITY (iOS 9): HeapAgent did not exist.
> +	   if (WI.mainTarget.HeapAgent)

Normally this is just `if (window.HeapAgent)` I think its a little weird to use
`WI.mainTarget`.