[webkit-reviews] review granted: [Bug 185322] ASSERT(!childItemWithTarget(child->target())) is hit in HistoryItem::addChildItem() : [Attachment 339630] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 185322: ASSERT(!childItemWithTarget(child->target())) is hit in
HistoryItem::addChildItem()
https://bugs.webkit.org/show_bug.cgi?id=185322

Attachment 339630: Patch

https://bugs.webkit.org/attachment.cgi?id=339630&action=review




--- Comment #8 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 339630
  --> https://bugs.webkit.org/attachment.cgi?id=339630
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339630&action=review

r=me

> Source/WebCore/ChangeLog:10
> +	   and for things like restoring form state from an HistoryItem.

a HistoryItem

> Source/WebCore/ChangeLog:15
> +	   would not take care of updating existing Frames's unique name on
frame tree mutation.

Frames'