[webkit-reviews] review granted: [Bug 185376] Update MediaSession to use release logging : [Attachment 339723] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 7 09:19:50 PDT 2018


youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 185376: Update MediaSession to use release logging
https://bugs.webkit.org/show_bug.cgi?id=185376

Attachment 339723: Patch

https://bugs.webkit.org/attachment.cgi?id=339723&action=review




--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 339723
  --> https://bugs.webkit.org/attachment.cgi?id=339723
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339723&action=review

> Source/WebCore/html/MediaElementSession.cpp:135
> +	   INFO_LOG(LOGIDENTIFIER, "adding ", restrictionName(restriction));

There might be cases where would want to log even if m_restrictions &
restriction is true.
Shouldn't we inverse m_restrictions before doing the &?


More information about the webkit-reviews mailing list